Skip to content

INFRA-388 Converting smartmon into python and adding mock tests #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: stackhpc/2024.1
Choose a base branch
from
Open

INFRA-388 Converting smartmon into python and adding mock tests #1327

wants to merge 16 commits into from
+762 −211

Conversation

technowhizz
Copy link
Contributor

No description provided.

@technowhizz technowhizz self-assigned this Oct 11, 2024
dougszumski
dougszumski reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great start, many thanks. It would be good to investigate external libraries for the smart data collection / parsing.

@Alex-Welsh Alex-Welsh added stackhpc-ci Caracal Targets the Caracal OpenStack release labels Nov 15, 2024
@Alex-Welsh Alex-Welsh added enhancement New feature or request and removed stackhpc-ci labels Nov 22, 2024
@technowhizz technowhizz changed the title Converting smartmon into python and adding mock tests INFRA-388 Converting smartmon into python and adding mock tests Dec 13, 2024
dougszumski
dougszumski reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @technowhizz , good effort.

@technowhizz technowhizz marked this pull request as ready for review May 1, 2025 18:22
@technowhizz technowhizz requested a review from a team as a code owner May 1, 2025 18:22
@technowhizz technowhizz requested a review from dougszumski May 1, 2025 18:26
@technowhizz technowhizz added the monitoring All things related to observability & telemetry label May 1, 2025
dougszumski
dougszumski approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @technowhizz . Let's merge and then iterate it on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougszumski dougszumski dougszumski approved these changes

Assignees

@technowhizz technowhizz

Labels
Caracal Targets the Caracal OpenStack release enhancement New feature or request monitoring All things related to observability & telemetry size: l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@technowhizz @dougszumski @Alex-Welsh